[PATCH] osmo-bts[master]: LC15: common/oml.c: Alarm - Unsupported BTS attributes

[Minh-Quang Nguyen]

Review at  https://gerrit.osmocom.org/252

LC15: common/oml.c: Alarm - Unsupported BTS attributes

Change-Id: I1a515a8fca128b924c82d8a88eb5d420e14b3604
---
M src/common/oml.c
1 file changed, 34 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/52/252/1

diff --git a/src/common/oml.c b/src/common/oml.c
index 2277c37..ccafc66 100644
--- a/src/common/oml.c
+++ b/src/common/oml.c
@@ -495,24 +495,56 @@
 	struct gsm_bts_role_bts *btsb = bts_role_bts(bts);
 	int rc, i;
 	const uint8_t *payload;
+	char log_msg[100];
+	struct gsm_failure_evt_rep failure_rep;
 
 	abis_nm_debugp_foh(DOML, foh);
 	DEBUGPC(DOML, "Rx SET BTS ATTR\n");
 
 	rc = oml_tlv_parse(&tp, foh->data, msgb_l3len(msg) - sizeof(*foh));
-	if (rc < 0)
+	if (rc < 0) {
+		snprintf(log_msg, 100, "New value for Attribute not supported\n");
+		LOGP(DOML, LOGL_NOTICE,"%s", log_msg);
+		failure_rep.event_type = NM_EVT_PROC_FAIL;
+		failure_rep.event_serverity = NM_SEVER_MAJOR;
+		failure_rep.cause_type = NM_PCAUSE_T_MANUF;
+		failure_rep.event_cause = NM_MM_EVT_MAJ_UNSUP_ATTR;
+		failure_rep.add_text = (char *)&log_msg;
+
+		oml_tx_failure_event_rep(&bts->mo, failure_rep);
 		return oml_fom_ack_nack(msg, NM_NACK_INCORR_STRUCT);
+	}
 
 	/* Test for globally unsupported stuff here */
 	if (TLVP_PRESENT(&tp, NM_ATT_BCCH_ARFCN)) {
 		uint16_t arfcn = ntohs(tlvp_val16_unal(&tp, NM_ATT_BCCH_ARFCN));
 		if (arfcn > 1024) {
-			LOGP(DOML, LOGL_NOTICE, "Given ARFCN %d is not supported.\n", arfcn);
+			snprintf(log_msg, 100, "Given ARFCN %d is not supported.\n",
+					arfcn);
+
+			LOGP(DOML, LOGL_NOTICE, "%s", log_msg);
+
+			failure_rep.event_type = NM_EVT_PROC_FAIL;
+			failure_rep.event_serverity = NM_SEVER_WARNING;
+			failure_rep.cause_type = NM_PCAUSE_T_MANUF;
+			failure_rep.event_cause = NM_MM_EVT_WARN_SW_WARN;
+			failure_rep.add_text = (char *)&log_msg;
+
+			oml_tx_failure_event_rep(&bts->mo, failure_rep);
 			return oml_fom_ack_nack(msg, NM_NACK_FREQ_NOTAVAIL);
 		}
 	}
 	/* 9.4.52 Starting Time */
 	if (TLVP_PRESENT(&tp, NM_ATT_START_TIME)) {
+		snprintf(log_msg, 100, "NM_ATT_START_TIME Attribute not supported\n");
+		LOGP(DOML, LOGL_NOTICE,"%s", log_msg);
+		failure_rep.event_type = NM_EVT_PROC_FAIL;
+		failure_rep.event_serverity = NM_SEVER_CRITICAL;
+		failure_rep.cause_type = NM_PCAUSE_T_MANUF;
+		failure_rep.event_cause = NM_MM_EVT_MAJ_UNSUP_ATTR;
+		failure_rep.add_text = (char *)&log_msg;
+
+		oml_tx_failure_event_rep(&bts->mo, failure_rep);
 		return oml_fom_ack_nack(msg, NM_NACK_SPEC_IMPL_NOTSUPP);
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/252
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a515a8fca128b924c82d8a88eb5d420e14b3604
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>