This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review-1 (7 comments) https://gerrit.osmocom.org/#/c/70/3/src/vty/command.c File src/vty/command.c: Line 418: _strlen = strlen(inp); Haha, I wanted to say that _strlen is not a good name. It clashes with reserved namespace of POSIX (_ prefix) and if (_strlen or if (strlen are easy to confuse and address of strlen will certainly be always > 0. Line 443: case '"': Why isn't it '|' here? https://gerrit.osmocom.org/#/c/70/3/src/vty/stats_vty.c File src/vty/stats_vty.c: Line 374: if (description) unconditionally talloc_free(description) please Line 410: if (description) talloc_free() directly Line 432: if (group_description) directly free this. free(NULL) and talloc_free(NULL) are well defined Line 459: if (description) directly release it. Line 483: if (group_description) and here too -- To view, visit https://gerrit.osmocom.org/70 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8af883167e5ee631059299b107ea83c8bbffdfb Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-HasComments: Yes