This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review+1 (2 comments) The only thing I find is that we are not running an activation timer in case of a handover. I think it is something we should fix mid-term. Can you either add it to your backlog or open a ticket in the osmocom.org tracker? https://gerrit.osmocom.org/#/c/210/1/openbsc/src/libbsc/abis_rsl.c File openbsc/src/libbsc/abis_rsl.c: Line 479: return rsl_ipacc_pdch_activate(lchan->ts, 0); * This routine might be called by rsl_rx_chan_rqd and bsc_handover_start In the later we don't run any activation timer (to detect broken channels). Can you add that to your backlog? I think we should have a timer running here. Line 1209: do_lchan_free(msg->lchan); Good. maybe add an OSMO_ASSERT to check that msg->lchan->state != NONE? -- To view, visit https://gerrit.osmocom.org/210 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59712b8769cc3959ef114a6e12e77801816fe8b6 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes