libosmocore[master]: add vty call show asciidoc: generate a documentation for cou...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jun 7 14:00:20 UTC 2016


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/70/2/src/vty/command.c
File src/vty/command.c:

Line 410: char *asciidoc_escape(const char *inp)
this introduces a new global symbol into a shared library, i.e. into the global namespace of every program that links the library.  We either have to keep an explciit .map file to hide those symbols (like we do with other osmocom libraries), or prefix it with osmo_*, or define it as static in the file where it is used...


-- 
To view, visit https://gerrit.osmocom.org/70
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8af883167e5ee631059299b107ea83c8bbffdfb
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list