[MERGED] openbsc[master]: Add warning for unsupported DTX configurations

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Jun 7 11:03:35 UTC 2016


Holger Freyther has submitted this change and it was merged.

Change subject: Add warning for unsupported DTX configurations
......................................................................


Add warning for unsupported DTX configurations

libosmo-abis do not consider DTX bits while processing TRAU frames. As I
do not have equipment to test it, I'm not sure if/how non-IP BTS will
work in case of DTX - warn users about it.

Change-Id: I94ee69cd309fc343a428ddc66942cd57f2a34c05
Related: OS#22
---
M openbsc/src/libbsc/bsc_vty.c
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c
index f4d47b4..b0f2f62 100644
--- a/openbsc/src/libbsc/bsc_vty.c
+++ b/openbsc/src/libbsc/bsc_vty.c
@@ -1748,7 +1748,9 @@
 	struct gsm_bts *bts = vty->index;
 
 	bts->dtxu = (argc > 0) ? GSM48_DTX_SHALL_BE_USED : GSM48_DTX_MAY_BE_USED;
-
+	if (!is_ipaccess_bts(bts))
+		vty_out(vty, "%% DTX enabled on non-IP BTS: this configuration "
+			"neither supported nor tested!%s", VTY_NEWLINE);
 	return CMD_SUCCESS;
 }
 
@@ -1771,7 +1773,9 @@
 	struct gsm_bts *bts = vty->index;
 
 	bts->dtxd = true;
-
+	if (!is_ipaccess_bts(bts))
+		vty_out(vty, "%% DTX enabled on non-IP BTS: this configuration "
+			"neither supported nor tested!%s", VTY_NEWLINE);
 	return CMD_SUCCESS;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/202
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94ee69cd309fc343a428ddc66942cd57f2a34c05
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list