libosmocore[master]: Add Finite State Machine abstraction code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Jun 7 10:55:14 UTC 2016


Patch Set 5:

(4 comments)

https://gerrit.osmocom.org/#/c/163/5/include/osmocom/core/fsm.h
File include/osmocom/core/fsm.h:

PS5, Line 40:  
const?


Line 44: 	void (*allstate_action)(struct osmo_fsm_inst *fi, uint32_t event, void *data);
Maybe also a _before_ and _after_ state has been transitioned?


https://gerrit.osmocom.org/#/c/163/5/src/fsm.c
File src/fsm.c:

Line 67:  *  logging can be used for the LU procedure of one subscriber, while
Mention time out handling as well and where would you attach state of a state? To the _inst or somewhere else? E.g. a pending msgb?


https://gerrit.osmocom.org/#/c/163/5/tests/testsuite.at
File tests/testsuite.at:

Line 208: cat $abs_srcdir/fsm/fsm_test.err > experr
Jacob had this list ordered to execute the long running tests last (bssgp-fc and timer). We have broken that quite some time agao but I think it would be nice to restore it.


-- 
To view, visit https://gerrit.osmocom.org/163
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b0965a912598c1f6b84042a99fea9d522642466
Gerrit-PatchSet: 5
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list