[MERGED] osmo-pcu[master]: tbf_dl: comment why we sent a dummy LLC packets to delay the...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Jun 7 10:42:19 UTC 2016


Holger Freyther has submitted this change and it was merged.

Change subject: tbf_dl: comment why we sent a dummy LLC packets to delay the release of the TBF
......................................................................


tbf_dl: comment why we sent a dummy LLC packets to delay the release of the TBF

Change-Id: I1862674437dffef4de3ffa7b183ecf690020b0ec
Reviewed-on: https://gerrit.osmocom.org/143
Reviewed-by: Harald Welte <laforge at gnumonks.org>
Tested-by: Jenkins Builder
---
M src/tbf_dl.cpp
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp
index da6628a..0cd6b76 100644
--- a/src/tbf_dl.cpp
+++ b/src/tbf_dl.cpp
@@ -515,6 +515,8 @@
 		bool is_final;
 
 		if (m_llc.frame_length() == 0) {
+			/* nothing to sent - delay the release of the TBF */
+
 			int space = block_data_len - write_offset;
 			/* A header will need to by added, so we just need
 			 * space-1 octets */

-- 
To view, visit https://gerrit.osmocom.org/143
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1862674437dffef4de3ffa7b183ecf690020b0ec
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list