This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 6: (7 comments) https://gerrit.osmocom.org/#/c/73/6/src/sccp.c File src/sccp.c: Line 157: if (ai & sccp_variant[sccp_system.variant].ai_pc_ind) { \ In the long run we need to aim for dual ansi/itu support but it is good enough for this iteration. Line 195: addr->gti_len = length - read; Was the length wrong before? Do we have a test case for this? Line 538: if (sock->gti_data) ai[0] = (sock->gti_ind & 0x0f) << 2; Line wrap please Line 539: if (sock->route_ind || !sock->gti_data) ai[0] |= sccp_variant[sccp_system.variant].ai_route_ind; line wrap after the if please Line 542: if (sock->national) ai[0] |= sccp_variant[sccp_system.variant].ai_national; dito Line 545: if (sock->use_poi) ai[0] |= sccp_variant[sccp_system.variant].ai_pc_ind; dito Line 554: if (!poi) return -1; \ line wrap -- To view, visit https://gerrit.osmocom.org/73 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17eef8c9b7d8e1092c587f469b4a68aa9702651 Gerrit-PatchSet: 6 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Arran Cudbard-bell <a.cudbardb at freeradius.org> Gerrit-Reviewer: Arran Cudbard-bell <a.cudbardb at freeradius.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes