This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 3: Code-Review-2
(2 comments)
added (c) notice, two things yet to be resolved.
https://gerrit.osmocom.org/#/c/192/3/openbsc/src/libiu/iu.c
File openbsc/src/libiu/iu.c:
Line 77: struct osmo_sua_link *link;
(comment from Patch Set 2 still valid)
Line 694: printf("sccp_sap_up(%s)\n", osmo_scu_prim_name(oph));
we should not have printf()s here. (x4 below)
--
To view, visit https://gerrit.osmocom.org/192
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffc26f9c73cb15463948f7435b72ac1747aabdb3
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes