openbsc[master]: dyn PDCH: allow allocating TCH/F on TCH/F_PDCH slots

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Jun 5 23:56:02 UTC 2016


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/180/1//COMMIT_MSG
Commit Message:

PS1, Line 9: See comment added in the code.
> this is not helpful. can you please write a (short) summary or remove this 
Ok, "see comment" disrupts the commit log reading experience, but in fact there's not much to add to the summary line. Instead I would drop this line from the commit log, or just say "Add comment".


https://gerrit.osmocom.org/#/c/180/2/openbsc/src/libbsc/chan_alloc.c
File openbsc/src/libbsc/chan_alloc.c:

Line 100: 		 * pchan must match; but when looking for TCH/F, allow a match
> not sure if I understand the code fully, but we sould always try to finda "
Good point, I didn't catch this causality in jolly's patch.
Will fix.


-- 
To view, visit https://gerrit.osmocom.org/180
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd575873a2fe819fc182a6b3d4186caea1997e5
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list