openbsc[master]: add libiu

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Jun 5 09:49:57 UTC 2016


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/192/2/openbsc/src/libiu/iu.c
File openbsc/src/libiu/iu.c:

Line 1: #include <stdint.h>
copyright statement and AGPLv3+ header missing


Line 57: 	struct osmo_sua_link *link;
as it is a SCCP User SAP, we should hide the sua specific bits inside the implementation and have users (like libiu) use a 'struct osmo_sccp_link' instead.


-- 
To view, visit https://gerrit.osmocom.org/192
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffc26f9c73cb15463948f7435b72ac1747aabdb3
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list