osmo-pcu[master]: Extend BTS <-> PCU protocol with measurement

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jul 29 16:41:16 UTC 2016


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/624/2/src/pcu_l1_if.cpp
File src/pcu_l1_if.cpp:

PS2, Line 219: set_ber(data_ind->ber10k / 100);
You're again loosing all your precision here. The result is a percentage, which is way too coarse.  Look at the RxQual definitions in GSM, just to get an idea about what they differentiate in the CS side: http://www.rfwireless-world.com/Terminology/GPRS-RxQUAL-vs-BER.html

0.26-0.3% is one of the rxqual bands.

I'm not saying RxQual has much significance in the GPRS context, but it is a good indication that you certainly don't want to loose all your resolution here.


-- 
To view, visit https://gerrit.osmocom.org/624
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0e29b668ee38516605c1763fda85e87e867813
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list