[MERGED] openbsc[master]: error log: rsl_chan_activate_lchan: log channel mode error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jul 28 16:56:54 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: error log: rsl_chan_activate_lchan: log channel mode error
......................................................................


error log: rsl_chan_activate_lchan: log channel mode error

Change-Id: I0f403b13ff9897770c0b855bf57a9440717b46e8
---
M openbsc/src/libbsc/abis_rsl.c
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c
index 6ddb088..e50e332 100644
--- a/openbsc/src/libbsc/abis_rsl.c
+++ b/openbsc/src/libbsc/abis_rsl.c
@@ -447,8 +447,12 @@
 	struct gsm48_chan_desc cd;
 
 	rc = channel_mode_from_lchan(&cm, lchan);
-	if (rc < 0)
+	if (rc < 0) {
+		LOGP(DRSL, LOGL_ERROR,
+		     "%s Cannot find channel mode from lchan type\n",
+		     gsm_ts_and_pchan_name(lchan->ts));
 		return rc;
+	}
 
 	/* If a TCH_F/PDCH TS is in PDCH mode, deactivate PDCH first. */
 	if (lchan->ts->pchan == GSM_PCHAN_TCH_F_PDCH

-- 
To view, visit https://gerrit.osmocom.org/591
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f403b13ff9897770c0b855bf57a9440717b46e8
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels_test_account <neels at hofmeyr.de>



More information about the gerrit-log mailing list