This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-2 (2 comments) https://gerrit.osmocom.org/#/c/624/1/src/pcuif_proto.h File src/pcuif_proto.h: PS1, Line 53: ber this will never work. You need to work with 1/10, 1/100 or 1/1000 percent. Look at the value ranges. You will need to communicate something like 0.2% here. Also, rach_ind already uses 'ber10k', why not simply use that? PS1, Line 55: lqual Also here. How do you want to express fractional amounts? What about a limit of 0.4dB? There's plenty of existing code in osmo-bts which communicates BER and quality as integers,. see btsb->min_qual_norm and the like. -- To view, visit https://gerrit.osmocom.org/624 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide0e29b668ee38516605c1763fda85e87e867813 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes