openbsc[master]: libmsc: add missing count of sms no receiver when using smpp...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jul 28 09:31:45 UTC 2016


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/501/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:

Line 323: 			/* FIXME: handle the error somehow? */
> it should be 41 as mentioned in the spec. we should also use the already de
please send separate additional patches, one for converting magic numbers to enum's, the other one to fix the wrong value (indicating the exact spec number + chapter number indicating the correct behavior)


-- 
To view, visit https://gerrit.osmocom.org/501
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20ecb3299d67dbaa7b016620685997db49970ffb
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list