This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 I'm no entirely sure about this. 1) there is no use of l1sap primitives/structures inside the pcu_sock code so far 2) at the very least, you need to include l1sap.h from pcu_if.h as you use a structure that's not defined anywhere 3) all the other API functions of pcu_if.h have individual primitive data types as arguments and don't use complex structs. So you are making the interface inconsistent. I think either all functions take primitive types, or all relatd functions (pcu_tx_rts_req, pcu_tx_rach_ind) take 'struct ph_*_param' as argument. -- To view, visit https://gerrit.osmocom.org/611 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib196a36ae2bae36d37144337bed71f40414dbb64 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No