This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/434/4/src/osmo-bts-sysmo/l1_if.h
File src/osmo-bts-sysmo/l1_if.h:
PS4, Line 45:
:
you're not using the enum that I had asked in my previous commit, sorry. The values are defined in an enum of the PHY that we use, so please simply use that enum.
Defining the same literal values to differnt symbolic names again will only cause likely breakage further down the road. Who will manually make sure that the two definitions are always kept in sync for the many years to come?
--
To view, visit https://gerrit.osmocom.org/434
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93831ddfb3f31b637e6a576f23a9bb4557758582
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-HasComments: Yes