This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/614/1/openbsc/src/libbsc/net_init.c File openbsc/src/libbsc/net_init.c: Line 49: 2, &default_regexp) != 0) Why 2? It looks like you intend to set the strlen from 1 to 2, but this is the argc argument, no strlen. Oddly enough, gsm_parse_reg() basically handles argc as a boolean. Only argv[0] will ever be parsed. :) -- To view, visit https://gerrit.osmocom.org/614 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20284b3d40ecf4ca1e67d8cd25afb8d5e4ae3025 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes