This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 7: (5 comments) https://gerrit.osmocom.org/#/c/537/6/src/tbf_ul.cpp File src/tbf_ul.cpp: Line 445: block->block_info.data_len = block->len; How is that replaced now? rlc_data and block->block pointed/aliased the same memory. I am a bit lost here. You copied the content starting from block->block[0] to block->block[block->len] but then use rlc_data (block->block[0]) as buffer? So you simply removed a copy of the data (as bllocks were not overlapping)? https://gerrit.osmocom.org/#/c/537/7/src/tbf_ul.cpp File src/tbf_ul.cpp: Line 448: return EGPRS_RESEG_DEFAULT; Sorry. I was replying about the 0x03 vs. 0x04 and now look more carefully at the state values. Do you want to return spb_status->block_status_ul here and in the other branches? At least the value of status_ul and return will stay in sync? https://gerrit.osmocom.org/#/c/537/7/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: Line 754: EGPRS_RESEG_DEFAULT); Check the assembled data here? Can you do that? And reset the data again? Line 1020: OSMO_ASSERT(ul_tbf->m_rlc.block(5)->cs_last == check the MCS once by hand as well. Maybe when you have block->len == 74? Line 1033: )); good. -- To view, visit https://gerrit.osmocom.org/537 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ca53218b6e0982abc2ab9c703c24c8bf0a09c0 Gerrit-PatchSet: 7 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes