This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/536/4/src/rlc.h File src/rlc.h: Line 82: EGPRS_RESEG_INVALID > Ok. I will assign it with value 3 Unless my understanding of enum is wrong INVALID right now is 0x03. The issue with 0x03 is that it is like EGPRS_RESEG_FIRST_SEG_RXD | EGPRS_RESEG_SECOND_SEG_RXD. Do you consider this state as invalid? To me it would be "done". If you want that please assign INVALID = ..._FIRST | _..SECOND otherwise use INVALID = 0x4. (taking the next bit) Sorry if I didn't make myself clear before. Do you see my point? -- To view, visit https://gerrit.osmocom.org/536 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83ccd136bb361adcfd511c57c5a9d95ed72c36c2 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes