This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 7: (5 comments) https://gerrit.osmocom.org/#/c/537/6/src/tbf_ul.cpp File src/tbf_ul.cpp: Line 230: egprs_rlc_ul_reseg_bsn_state assemble_status; > Add ; Ok. I will modify the same. Line 390: uint8_t *data, const uint8_t block_idx) > if you drop struct here, does the line fit within 80 chars? if yes, please I will modify the same Line 443: block_idx, data, rlc_data); > Why is that memmove necessary? ok. I will realign the code. Line 495: * upgrade the MCS to the type 2 > please include the spb value seen here. Yes it should not happen but a log I will update it. Line 521: return assemble_status; > print the CS? I will update it. -- To view, visit https://gerrit.osmocom.org/537 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ca53218b6e0982abc2ab9c703c24c8bf0a09c0 Gerrit-PatchSet: 7 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes