This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 6: Code-Review-1 (7 comments) https://gerrit.osmocom.org/#/c/537/6/src/tbf.h File src/tbf.h: Line 443: const struct gprs_rlc_data_info *rlc, struct gprs_rlc_data *block, please indent parameters one level more. this way all functions can be clearly seen. https://gerrit.osmocom.org/#/c/537/6/src/tbf_ul.cpp File src/tbf_ul.cpp: Line 230: egprs_rlc_ul_reseg_bsn_state re_assemble_status = Add ; and make assignment in the next line, shorten the variable name as well please. Line 390: const struct gprs_rlc_data_block_info *rdbi = if you drop struct here, does the line fit within 80 chars? if yes, please do it. Line 443: Why is that memmove necessary? Line 495: name()); please include the spb value seen here. Yes it should not happen but a log message should tell us. Line 521: "--%s: Error in Upgrading to higher MCS\n", print the CS? https://gerrit.osmocom.org/#/c/537/6/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: Line 1829: test_tbf_egprs_two_phase_spb(); Can you please add one more simple unit test of mostly the re-segmentation? * Receive First, the second * Receive First, First then Second * Receive Second then First and compare how the gprs_rlc_data* is looking after? It seems to be a rather easy test case without much parsing or state setup (e.g. the tbf can be partially initialized). -- To view, visit https://gerrit.osmocom.org/537 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ca53218b6e0982abc2ab9c703c24c8bf0a09c0 Gerrit-PatchSet: 6 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes