This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 4: (3 comments) Sorry, three more comments https://gerrit.osmocom.org/#/c/536/4/src/rlc.h File src/rlc.h: Line 82: EGPRS_RESEG_INVALID this should be 0x4 then as otherwise it is 3? Line 142: /* TODO: DL split block status need to be supported same here or make it single line /* COMMENT */ Line 173: union split_block_status spb_status_current; Why _current? Do you expect a _past? state as well? If not please remove. -- To view, visit https://gerrit.osmocom.org/536 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83ccd136bb361adcfd511c57c5a9d95ed72c36c2 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes