[PATCH] osmo-bts[master]: dyn TS: implement SysmoBTS specifics

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/607

dyn TS: implement SysmoBTS specifics

For chan_nr_by_sapi(), add GSM_PCHAN_TCH_F_TCH_H_PDCH to pick_pchan().

Add GSM_PCHAN_TCH_F_TCH_H_PDCH to pchan_to_logChComb[] for first pchan
initialization.

In ts_connect_as(), make sure that callers pass proper "real world" pchan
types, i.e. reject the "meta" GSM_PCHAN_TCH_F_TCH_H_PDCH pchan constant.

In ts_opstart(), connect as PCHAN_NONE since we will only know the desired
pchan when the first RSL chan activ is received.

Add GSM_PCHAN_TCH_F_TCH_H_PDCH to lchan_to_GsmL1_SubCh_t(), by using its
current "real" pchan mode.

Call cb_ts_[dis]connected() unconditionally, i.e. not only for TCH_F_PDCH when
a pending flag is set. The cb_ts_[dis]connected() will be a no-op if the pchan
type is not dynamic.

Change-Id: Iaffd2fc0aa9fc6c4a2acbc534ce6384392e0635b
---
M src/osmo-bts-sysmo/l1_if.c
M src/osmo-bts-sysmo/oml.c
2 files changed, 33 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/07/607/1

diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index 355507d..2dcd87e 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -607,11 +607,16 @@
 
 static enum gsm_phys_chan_config pick_pchan(struct gsm_bts_trx_ts *ts)
 {
-	if (ts->pchan != GSM_PCHAN_TCH_F_PDCH)
+	switch (ts->pchan) {
+	case GSM_PCHAN_TCH_F_PDCH:
+		if (ts->flags & TS_F_PDCH_ACTIVE)
+			return GSM_PCHAN_PDCH;
+		return GSM_PCHAN_TCH_F;
+	case GSM_PCHAN_TCH_F_TCH_H_PDCH:
+		return ts->dyn.pchan_is;
+	default:
 		return ts->pchan;
-	if (ts->flags & TS_F_PDCH_ACTIVE)
-		return GSM_PCHAN_PDCH;
-	return GSM_PCHAN_TCH_F;
+	}
 }
 
 static uint8_t chan_nr_by_sapi(struct gsm_bts_trx_ts *ts,
diff --git a/src/osmo-bts-sysmo/oml.c b/src/osmo-bts-sysmo/oml.c
index 00c00fe..585e6d0 100644
--- a/src/osmo-bts-sysmo/oml.c
+++ b/src/osmo-bts-sysmo/oml.c
@@ -88,6 +88,8 @@
 	[GSM_PCHAN_PDCH]		= GsmL1_LogChComb_XIII,
 	[GSM_PCHAN_TCH_F_PDCH]		= GsmL1_LogChComb_I, /*< first init
 						like TCH/F, until PDCH ACT */
+	[GSM_PCHAN_TCH_F_TCH_H_PDCH]	= GsmL1_LogChComb_0, /*< first unused,
+						until first RSL CHAN ACT */
 	[GSM_PCHAN_UNKNOWN]		= GsmL1_LogChComb_0,
 };
 
@@ -489,6 +491,14 @@
 	struct femtol1_hdl *fl1h = trx_femtol1_hdl(ts->trx);
 	GsmL1_MphConnectReq_t *cr;
 
+	if (pchan == GSM_PCHAN_TCH_F_TCH_H_PDCH) {
+		LOGP(DL1C, LOGL_ERROR,
+		     "%s Requested TS connect as %s,"
+		     " expected a specific pchan instead\n",
+		     gsm_ts_and_pchan_name(ts), gsm_pchan_name(pchan));
+		return -EINVAL;
+	}
+
 	cr = prim_init(msgb_l1prim(msg), GsmL1_PrimId_MphConnectReq, fl1h,
 		       l1p_handle_for_ts(ts));
 	cr->u8Tn = ts->nr;
@@ -503,6 +513,11 @@
 
 static int ts_opstart(struct gsm_bts_trx_ts *ts)
 {
+	if (ts->pchan == GSM_PCHAN_TCH_F_TCH_H_PDCH) {
+		/* First connect as NONE, until first RSL CHAN ACT. */
+		ts->dyn.pchan_is = ts->dyn.pchan_want = GSM_PCHAN_NONE;
+		return ts_connect_as(ts, GSM_PCHAN_NONE, opstart_compl_cb, NULL);
+	}
 	return ts_connect_as(ts, ts->pchan, opstart_compl_cb, NULL);
 }
 
@@ -523,7 +538,12 @@
 
 GsmL1_SubCh_t lchan_to_GsmL1_SubCh_t(const struct gsm_lchan *lchan)
 {
-	switch (lchan->ts->pchan) {
+	enum gsm_phys_chan_config pchan = lchan->ts->pchan;
+
+	if (pchan == GSM_PCHAN_TCH_F_TCH_H_PDCH)
+		pchan = lchan->ts->dyn.pchan_want;
+
+	switch (pchan) {
 	case GSM_PCHAN_CCCH_SDCCH4:
 	case GSM_PCHAN_CCCH_SDCCH4_CBCH:
 		if (lchan->type == GSM_LCHAN_CCCH)
@@ -540,6 +560,7 @@
 	case GSM_PCHAN_TCH_F_PDCH:
 	case GSM_PCHAN_UNKNOWN:
 	default:
+	/* case GSM_PCHAN_TCH_F_TCH_H_PDCH: is caught above */
 		return GsmL1_SubCh_NA;
 	}
 
@@ -1866,8 +1887,7 @@
 	LOGP(DL1C, LOGL_DEBUG, "%s Rx mphDisconnectCnf\n",
 	     gsm_lchan_name(ts->lchan));
 
-	if (ts->flags & TS_F_PDCH_PENDING_MASK)
-		cb_ts_disconnected(ts);
+	cb_ts_disconnected(ts);
 
 	return 0;
 }
@@ -1901,8 +1921,7 @@
 	       ts->flags & TS_F_PDCH_ACT_PENDING ? "ACT_PENDING " : "",
 	       ts->flags & TS_F_PDCH_DEACT_PENDING ? "DEACT_PENDING " : "");
 
-	if (ts->flags & TS_F_PDCH_PENDING_MASK)
-		cb_ts_connected(ts);
+	cb_ts_connected(ts);
 
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/607
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaffd2fc0aa9fc6c4a2acbc534ce6384392e0635b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>