[PATCH] openbsc[master]: error log: abis_rsl.c: log errors in channel_mode_from_lchan()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jul 25 15:57:02 UTC 2016


Review at  https://gerrit.osmocom.org/586

error log: abis_rsl.c: log errors in channel_mode_from_lchan()

Change-Id: Ifa416eab76e6c26dc83e979d815ae778d0d7133b
---
M openbsc/src/libbsc/abis_rsl.c
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/86/586/1

diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c
index baefd54..a0faf25 100644
--- a/openbsc/src/libbsc/abis_rsl.c
+++ b/openbsc/src/libbsc/abis_rsl.c
@@ -342,6 +342,9 @@
 	case GSM_LCHAN_NONE:
 	case GSM_LCHAN_UNKNOWN:
 	default:
+		LOGP(DRSL, LOGL_ERROR,
+		     "unsupported activation lchan->type %u %s\n",
+		     lchan->type, gsm_lchant_name(lchan->type));
 		return -EINVAL;
 	}
 
@@ -375,6 +378,9 @@
 				cm->chan_rate = RSL_CMOD_SP_NT_6k0;
 				break;
 			default:
+				LOGP(DRSL, LOGL_ERROR,
+				     "unsupported lchan->tch_mode %u\n",
+				     lchan->tch_mode);
 				return -EINVAL;
 			}
 			break;
@@ -404,9 +410,15 @@
 			cm->chan_rate = RSL_CMOD_CSD_T_32000;
 			break;
 		default:
+			LOGP(DRSL, LOGL_ERROR,
+			     "unsupported lchan->csd_mode %u\n",
+			     lchan->csd_mode);
 			return -EINVAL;
 		}
 	default:
+		LOGP(DRSL, LOGL_ERROR,
+		     "unsupported lchan->tch_mode %u\n",
+		     lchan->tch_mode);
 		return -EINVAL;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/586
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa416eab76e6c26dc83e979d815ae778d0d7133b
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list