osmo-pcu[master]: Add test case for decompression of compressed bitmap

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sun Jul 24 14:31:47 UTC 2016


Patch Set 3:

> > Please see the GPRS mailinglist for the path of merging the tree
 > > based code. This change as such will not be merged to the PCU.
 > 
 > As you suggested,
 > 1. I have changed all malloc memory allocation to talloc.

talloc is a hierachical allocator with named contexts. Your tree building is not making use of this. The hierarchy helps with clean-up and is useful during memory allocation dumps (SIGUSR1)
 

 > 2. Added test vectors taken from libosmocore in tbf_test.cpp.

Yes, but see my mailinglist post. The test from libosmocore needs to be copied. The tree based decoder should not have less test coverage than the one in libosmocore.


 > 3. Return value from the search_runlen & decompress_crbb are
 > handled properly.

yes, on the surface it looks good. The general approach seems fine I have not looked at the details yet.

 > 4. Invalid inputs were added in the test vector with suppression of
 > verification.

good.

 > 5. Code duplication is removed in decompress_crbb.

good. code duplication and coding style issues are still in the tree building

 > The only points that were missing are as below, and that will be
 > corrected and submitted in next set
 > 1. Freeing of context tall_pcu_ctx recursively frees all its
 > children so, there is no need to call separate function to free the
 > memory allocated for tree.

well tall_pcu_ctx is the global one. Every talloc allocation is a context. So you would create one for your two roots by allocating the roots and then the children are either all children of the root or children of their parent leaf.

 > 2. Same commit will be used for source and test.

good.

3. Add separate test for the decoding, take test data and results from libosmocore
4. Remove the timing part. We know it is more quick and the printing of timings was missing anyway

-- 
To view, visit https://gerrit.osmocom.org/417
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f26ec3d9eeace4ea8396ad5786a988fb58cf445
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: pravin <pravin.manoharan at radisys.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list