openbsc[master]: Modify SI 13 field to support 11 bit RACH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Jul 18 09:46:44 UTC 2016


Patch Set 3: Code-Review-1

(2 comments)

I think it would be less surprising to users if "gprs 11bit_rach_support" would also turn on support for 11bit rach in gprs. Right now it enables it for egprs while leaving gprs with 8bit rach. Please also change commit message and vty help strings accordingly.

https://gerrit.osmocom.org/#/c/436/3/openbsc/src/libbsc/bsc_vty.c
File openbsc/src/libbsc/bsc_vty.c:

Line 2731: 
What's the point of this define? It doesn't seem to be used anywhere else so why not use the string directly?


https://gerrit.osmocom.org/#/c/436/3/openbsc/src/libbsc/rest_octets.c
File openbsc/src/libbsc/rest_octets.c:

Line 652: 
I think you should also set ACCESS_BURST_TYPE bit above which is now hardcoded to 8-bit.


-- 
To view, visit https://gerrit.osmocom.org/436
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51357bec936c28a26ab9ff5d59e0e30ca3363297
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list