libosmocore[master]: Update structure in libosmocore for 11 bit RACH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

bhargava_abhyankar gerrit-no-reply at lists.osmocom.org
Mon Jul 18 05:41:23 UTC 2016


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/427/2/include/osmocom/gsm/l1sap.h
File include/osmocom/gsm/l1sap.h:

Line 52: 	GSM_L1_BURST_TYPE_ACCESS_0,
> Why did you drop the ACCESS_0 = 4 here? I thought you wanted this to match 
ACCESS_0 = 4 is specific only to osmo-bts-sysmo. As suggested by you, to make it generic with all bts models, it has been dropped in libosmocore. The mapping between the enum and bts specific values should be done at respective bts. For osmo-bts-sysmo the mapping is done. With this change osmo-pcu work for other bts models as well without need of any further change.


-- 
To view, visit https://gerrit.osmocom.org/427
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f0f2424a3af7599d986044be25ea4fcc0ca477
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list