This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review-1 (6 comments) Mostly good. * Please describe your manual test setup * Maybe introduce a KPI for counting how often we resegmented (or failed) * See if OSMO_ASSERT is not triggerable by a rogue MS https://gerrit.osmocom.org/#/c/537/3//COMMIT_MSG Commit Message: Line 13: in NuRAN 1.0 hardware thoroughly. The scope of Unit testing is limited. How did your manual test look? How did you trigger the downgrade? https://gerrit.osmocom.org/#/c/537/1/src/tbf_ul.cpp File src/tbf_ul.cpp: Line 442: > I agree. I will modify the same. can we get the tbf in the log message (and for the other segment as well)? Line 520: } > valid combination of assembling are MCS1->MCS4, MCS2->MCS5, MCS3->MCS6 (ref In general OSMO_ASSERT(false) should not be used for input coming from the air interface (remote MS). As otherwise a single MS can force a denial of service (DoS). Is rlc->cs controllable by the MS? https://gerrit.osmocom.org/#/c/537/3/src/tbf_ul.cpp File src/tbf_ul.cpp: Line 400: LOGP(DRLCMACUL, LOGL_DEBUG, Please put the info about the tbf into the log as well. Line 413: "--- Second seg is received " ditto Line 517: OSMO_ASSERT(false); The main question I have is: * Is rlc->cs controlled by the MS * Can it force resegmentation even if it would not be needed (e.g. use MCS9 but send a different header type meant for lower mcs) The concern is that we do not want to have an OSMO_ASSERT(false) for input controlled by the MS. This can lead to a Denial of Service and that is obviously not good. -- To view, visit https://gerrit.osmocom.org/537 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ca53218b6e0982abc2ab9c703c24c8bf0a09c0 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes