This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/544/1/src/pcu_vty_functions.cpp File src/pcu_vty_functions.cpp: Line 194: bool set_tbf_ta(struct gprs_rlcmac_bts *bts_data, uint32_t fn, it's a bit odd to introduce this function in pcu_vty_functions.c, don't you think? Yes, it might be used from a debugging vty command, but then, as it is used by other code, it should be a generic function thta's also occasionally used from the vty, right? -- To view, visit https://gerrit.osmocom.org/544 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96fdbb20b09fb85fdd9fb6dcf3c25f6bee7f80e4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes