osmo-pcu[master]: Add decoding of compressed bitmap in EPDAN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pravin gerrit-no-reply at lists.osmocom.org
Thu Jul 14 07:42:12 UTC 2016


Patch Set 3:

(2 comments)

> Ok, so this implements 44.060 §9.1.10. The gerrit #415 according to
 > your earlier claim implements entirely different algorithm. But
 > according to commit message in #415 it aims to replace existing
 > implementation in osmo_t4_decode()/_decode() which implements
 > exactly 44.060 §9.1.10. This is highly confusing. Please get in
 > touch with author of #415 to avoid double work for both developers
 > and reviewers.
1. 44.060, Section 9.1.10  has the description of compression/decompression & tables for code words.
2. #415 is for compression of data in PUAN message whereas #416 is for decompression of data In EPDAN message.
3. Tree based algorithm used only for decompression in EPDAN message.
4. Table based algorithm used for compression in PUAN message.

https://gerrit.osmocom.org/#/c/416/2/src/egprs_rlc_compression.h
File src/egprs_rlc_compression.h:

Line 28: extern const char *zero_run_len_code_list[MAX_CDWDTBL_LEN];
> whitespace matters, please do not add trailing whitespace
Done


Line 36: 	egprs_compress()
> here as well (display color red == bad)
Done


-- 
To view, visit https://gerrit.osmocom.org/416
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: pravin <pravin.manoharan at radisys.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list