This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/534/1/src/bitvector.h
File src/bitvector.h:
Line 47: return ::bitvec_write_field(bv, &write_index, val, len);
> Curious, have not seen this before. What's the advantage over extern "C"?
extern "C" just defines the symbol name (bitvec_write_field vs. _ZBasicC++Manglingbitvec_write_fieldManglingOfType1Type2Type3Type4).
:: is to search for a method in the outer scope. E.g. if you have
class Foo {
public:
ssize_t sendto(..same_args_as_c) {
return ::sendto()..
}
};
this should look for another method. I think I don't need the :: here but I want to show the intent of not causing an infinite recursion.
--
To view, visit https://gerrit.osmocom.org/534
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd16ce251a42bad4401c2bf3a8fa6af70fb600ff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes