osmo-pcu[master]: Add Accessor functions for ARQ-II in EGPRS DL

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Jul 12 16:44:14 UTC 2016


Patch Set 2:

(1 comment)

minor question.

https://gerrit.osmocom.org/#/c/333/2/src/gprs_coding_scheme.h
File src/gprs_coding_scheme.h:

Line 205: 	if (this->m_scheme == scheme)
have you considered just returning this->m_scheme == scheme; ?


-- 
To view, visit https://gerrit.osmocom.org/333
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefff956bf2dcfe8fb0b2f5a7a7a2122d5d555f9e
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list