osmo-pcu[master]: Modify DL tbf flow for ARQ-II in EGPRS DL Retx

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Jul 12 16:42:43 UTC 2016


Patch Set 2: Code-Review-1

(2 comments)

Please address coding style.

https://gerrit.osmocom.org/#/c/334/2/src/tbf_dl.cpp
File src/tbf_dl.cpp:

Line 378: 		 if (is_egprs_enabled()) {
extra whitespace. please remove


Line 392: 			 * dated 2016-02-07 23:45:40 (UTC)
unrelated but okay for now.


-- 
To view, visit https://gerrit.osmocom.org/334
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a845c98f2018795f0f62240f228411b0bc030c7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list