libosmocore[master]: Add EGPRS RLC/MAC headers from 3GPP TS 04.60

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jul 11 19:17:03 UTC 2016


Patch Set 1:

> They headers came from osmo-pcu, but white space and variable
 > naming (_hi/_lo instead of _a/_b) were modified to be consistent
 > with other parts of libosmocore.
 > 
 > Big-endian was not implemented in PCU, so that was added.

 > They headers came from osmo-pcu, but white space and variable
 > naming (_hi/_lo instead of _a/_b) were modified to be consistent
 > with other parts of libosmocore.
 
This is all fine with me, but if you move the headers from osmo-pcu to libosmocore (which is right!), theere needs to be a patch against osmo-pcu to actually use the new / renamed definitions from libosmocore.  Otherwise we just create another copy, which is what we wanted to avoid in the first place. Thanks!

-- 
To view, visit https://gerrit.osmocom.org/489
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I500cdc87cd30faf36c8cd92d234642f809c8f2aa
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Tom Tsou <tom at tsou.cc>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>
Gerrit-HasComments: No



More information about the gerrit-log mailing list