osmo-pcu[master]: Fix issues in URBB generation in EGPRS PUAN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

prasadkg gerrit-no-reply at lists.osmocom.org
Mon Jul 11 09:46:58 UTC 2016


Patch Set 1:

> Can you please come up with a testcase? If necessary and possible
 > just take the code out into a separate function you call from the
 > testcase.

The added test case test_tbf_egprs_two_phase_puan  is applicable to this patch also. Without this fix, the length of the bitmap in PUAN is 0 whereas after this fix, proper bitmap is generated. The length is getting logged and is currently getting tested by log comparison. I  will add a post condition to check it from the test.

-- 
To view, visit https://gerrit.osmocom.org/412
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5c25b6ee30f2f1b613e923c234b03a6ffe12ae2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: prasadkg <Prasad.Kaup at radisys.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: prasadkg <Prasad.Kaup at radisys.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list