This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/416/1/src/decoding.cpp File src/decoding.cpp: Line 33: #include <sys/time.h> re-add the empty line. we like them to separate things :) Line 700: decompress_crbb(desc->CRBB_LENGTH, desc->CRBB_STARTING_COLOR_CODE, desc->CRBB, bits); two tabs, you are still within the if and can you elaborate how decompress_crbb can not fail? https://gerrit.osmocom.org/#/c/416/1/src/egprs_rlc_compression.h File src/egprs_rlc_compression.h: Line 36: egprs_compress() make the d'tor private as well otherwise we will leak. Line 38: ones_list = (Node *)malloc(sizeof(Node)); As a general rule we use talloc (for its runtime inspection into memory allocations) https://gerrit.osmocom.org/#/c/416/1/src/pcu_main.cpp File src/pcu_main.cpp: Line 257: egprs_compress::instance()->decode_tree_init(); please don't just put code but align it according to the scope -- To view, visit https://gerrit.osmocom.org/416 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: Yes