This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/417/1/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: Line 86: int i = 0, bytes = 7; wrong indenting level and hard to read. The goal is to check i the remaining bits (< 8) are the same as expected? I think creating a bitmask based on the reminder and comparing that might make the code more comprehensible? Line 115: while (loop++ < test_run) { have the loop the other way around. You are hitting the same path in the tree all the time and this is unlikely to what will happen during execution. D-cache is not that big on the ARM7tdmi. -- To view, visit https://gerrit.osmocom.org/417 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f26ec3d9eeace4ea8396ad5786a988fb58cf445 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: Yes