osmo-pcu[master]: Add test cases to support ARQ-II for EGPRS DL Retx

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sat Jul 9 08:17:40 UTC 2016


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/335/1/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

Line 1347: 	/* TODO: Need to support of MCS8 -> MCS6 transistion */
> I will add more comments.
Even if redundant the pointer to be881c028fc4da00c4046ecd9296727975c206a3 will help someone just seeing this comment.

Alternative create a ticket and have a see OS#XXXX comment


Line 1368: 			((GprsCodingScheme::Scheme)(GprsCodingScheme::CS4 +
> There is no constructor attempted here. Below is the error we receive witho
Can you try adding an explicit constructor? If not possible please use a static_cast (if possible) instead of the liberal c cast.


-- 
To view, visit https://gerrit.osmocom.org/335
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia357acfe30f4dea95e00749916c6818354f93285
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list