This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/466/1/src/gsm/gsm_04_08_gprs.c
File src/gsm/gsm_04_08_gprs.c:
Line 140: const struct value_string gprs_mt_gmm_names[] = {
MT is usually "mobile terminated" in the GSM world. One could now think this value_string only contains mobile-terminated GMM messages. I think we more often use "msgt" or "msgtype" to decribe a message type". please adjust.
--
To view, visit https://gerrit.osmocom.org/466
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48477b733e2da72f59349c00554dd3e080c9f445
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes