This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/482/1/src/osmo-bts-trx/gsm0460.h
File src/osmo-bts-trx/gsm0460.h:
Line 9: struct gsm0460_egprs_dl_hdr_type1 {
don't we already have those kind of definitions in OsmoPCU? I would be surprised if we didn't. The proper course of action would be to move all related definitions to a header file in libosmocore's osmocom/gsm/protocol/ and then use that from both osmo-pcu and osmo-bts-trx.
--
To view, visit https://gerrit.osmocom.org/482
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f059ae34c6f36179553cbc972f8becf8179eb55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Tom Tsou <tom at tsou.cc>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes