osmo-bts[master]: lc15: add L3 handle to l1prim messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Jul 5 09:28:05 UTC 2016


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/392/2/src/osmo-bts-litecell15/l1_if.c
File src/osmo-bts-litecell15/l1_if.c:

Line 149: 	return 0;
> I had this in the other commit as well. If you return 0x0 here.. it should 
This is "just" a HANDLE being returned, like a random ID to match up request and response.

It is up to the caller of prim_init() in the BTS' oml.c to pass a meaningful hLayer3 handle, which the L1 will return transparently in the response.

There are some messages that simply don't have a hLayer3 handle, or messages where we don't set any because there is only one instance targeted (e.g. l1f_set_txpower() is global for the L1).

So the handles may be zero or missing entirely in both, and request and response will still match.


-- 
To view, visit https://gerrit.osmocom.org/392
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17f95ba744c3e944a2241809106506f8dd1b24f0
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list