openbsc[master]: Modify SI 13 field to support 11 bit RACH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jul 1 13:46:38 UTC 2016


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/436/1/openbsc/src/libbsc/bsc_vty.c
File openbsc/src/libbsc/bsc_vty.c:

Line 448: 		vty_out(vty, "  eleven_bit_rach_support%s",
> I have tried saving the configuration using write in vty for both support a
ok, sorry, my mistake. Thanks for clarification.

However, please move the 11bit rach part below the "gprs" command.  right now we have "gprs mode" as only command, let's add it as "gprs 11bit_rach_support (0|1)".

I know it is more "cisco style" to use the "no" syntax, but in OpenBSC we typically have the form as described in the above paragraph.

Please also make sure that a warning is printed if "gprs mode none" is selected, but somebody activates the 11bit mode.


-- 
To view, visit https://gerrit.osmocom.org/436
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51357bec936c28a26ab9ff5d59e0e30ca3363297
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list