[PATCH] openbsc[master]: fix 'osmo-nitb --version' segfault

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Dec 28 17:57:10 UTC 2016


Review at  https://gerrit.osmocom.org/1509

fix 'osmo-nitb --version' segfault

Call vty_init() before handle_options() to make sure the host.app_info is
populated before --version potentially tries to print it.

Change-Id: Ice91256d72b9eabd52709352ba6cc6a42af2921b
---
M openbsc/src/osmo-nitb/bsc_hack.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/09/1509/1

diff --git a/openbsc/src/osmo-nitb/bsc_hack.c b/openbsc/src/osmo-nitb/bsc_hack.c
index 992d4c8..bbcdd1b 100644
--- a/openbsc/src/osmo-nitb/bsc_hack.c
+++ b/openbsc/src/osmo-nitb/bsc_hack.c
@@ -269,6 +269,7 @@
 	osmo_init_logging(&log_info);
 	osmo_stats_init(tall_bsc_ctx);
 	bts_init();
+	vty_init(&vty_info);
 
 	/* Parse options */
 	handle_options(argc, argv);
@@ -282,7 +283,6 @@
 	}
 
 	/* Initialize VTY */
-	vty_init(&vty_info);
 	bsc_vty_init(&log_info, bsc_gsmnet);
 	ctrl_vty_init(tall_bsc_ctx);
 

-- 
To view, visit https://gerrit.osmocom.org/1509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice91256d72b9eabd52709352ba6cc6a42af2921b
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list