[MERGED] libosmocore[master]: fsm: log calling file+line for error "event for NULL fi"

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Dec 24 17:11:53 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: fsm: log calling file+line for error "event for NULL fi"
......................................................................


fsm: log calling file+line for error "event for NULL fi"

Change-Id: I1970773440865f1415004bcf0164603468acf90b
---
M src/fsm.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/fsm.c b/src/fsm.c
index 8675f75..c9902ae 100644
--- a/src/fsm.c
+++ b/src/fsm.c
@@ -384,8 +384,9 @@
 	const struct osmo_fsm_state *fs;
 
 	if (!fi) {
-		LOGP(DLGLOBAL, LOGL_ERROR, "Trying to dispatch event %u to "
-		     "non-existing FSM Instance!\n", event);
+		LOGPSRC(DLGLOBAL, LOGL_ERROR, file, line,
+			"Trying to dispatch event %u to non-existent"
+			" FSM instance!\n", event);
 		osmo_log_backtrace(DLGLOBAL, LOGL_ERROR);
 		return -ENODEV;
 	}

-- 
To view, visit https://gerrit.osmocom.org/1494
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1970773440865f1415004bcf0164603468acf90b
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list