This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/1487/1/openbsc/src/gprs/gprs_llc.c File openbsc/src/gprs/gprs_llc.c: Line 208: * modem when a modem originated XID is received. The function is please remove all those cosmetic changes from the functional change. And while you're at it, use terminology like MS/ME/UE which is reasonably generic. Either Phone or Modem is wrong, so the proposed change is not really an improvement. Also, why worry at all about it? Let's focus on what we really need to do, i.e. fix and improve the code... -- To view, visit https://gerrit.osmocom.org/1487 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I097a770cb4907418f53e620a051ebb8cd110c5f2 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-HasComments: Yes