[PATCH] osmo-hlr[master]: gsup: send subscriber MSISDN

[Neels Hofmeyr]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1454

to look at the new patch set (#2).

gsup: send subscriber MSISDN

Change-Id: Iace97a1a828b29ce11913a14243bcf80bbae9136
---
M src/hlr.c
1 file changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/54/1454/2

diff --git a/src/hlr.c b/src/hlr.c
index 3101403..674a58b 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -25,6 +25,7 @@
 #include <osmocom/core/application.h>
 #include <osmocom/gsm/gsup.h>
 #include <osmocom/gsm/apn.h>
+#include <osmocom/gsm/gsm48_ie.h>
 
 #include "db.h"
 #include "logging.h"
@@ -266,6 +267,7 @@
 {
 	struct osmo_gsup_message gsup;
 	uint8_t apn[APN_MAXLEN];
+	uint8_t msisdn_enc[43]; /* TODO use constant; TS 24.008 10.5.4.7 */
 	int l;
 
 	OSMO_ASSERT(luop->state == LU_S_LU_RECEIVED ||
@@ -274,8 +276,20 @@
 	memset(&gsup, 0, sizeof(gsup));
 	gsup.message_type = OSMO_GSUP_MSGT_INSERT_DATA_REQUEST;
 	strncpy(gsup.imsi, luop->subscr.imsi, sizeof(gsup.imsi)-1);
+
+	l = gsm48_encode_bcd_number(msisdn_enc, sizeof(msisdn_enc), 0,
+				    luop->subscr.msisdn);
+	if (l < 1) {
+		LOGP(DMAIN, LOGL_ERROR,
+		     "%s: Error: cannot encode MSISDN '%s'\n",
+		     luop->subscr.imsi, luop->subscr.msisdn);
+		lu_op_tx_error(luop, GMM_CAUSE_PROTO_ERR_UNSPEC);
+		return;
+	}
+	gsup.msisdn_enc = msisdn_enc;
+	gsup.msisdn_enc_len = l;
+
 	/* FIXME: deal with encoding the following data */
-	gsup.msisdn_enc;
 	gsup.hlr_enc;
 
 	if (luop->is_ps) {

-- 
To view, visit https://gerrit.osmocom.org/1454
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iace97a1a828b29ce11913a14243bcf80bbae9136
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder