openbsc[master]: Turn some warnings into errors

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Dec 21 10:34:30 UTC 2016


Patch Set 2: Code-Review-1

> Good point. -Werror=null-dereference and -Werror=sizeof-array-argument
 > are not supported by gcc 4.9.2. Is there particular gcc version we
 > care about?

I would say we shouldn't introduce arbitrary compiler dependencies without a good reason.  at the very least we shuold go back to 4.7.x, but probably further.

Why not use autoconf to check for those options and then conditionally enable them based on compiler support?

-- 
To view, visit https://gerrit.osmocom.org/1368
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied9c950dafa65f324cf31298b13b590f56139700
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list