This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/1459/1/src/hlr.c File src/hlr.c: Line 287: osmo_apn_from_str(gsup.pdp_infos[0].apn_enc, 2, "*"); I guess it would be easier to read, and also you should validate l, and rather pass the size of apn, with something like this: l = osmo_apn_from_str(apn, sizeof(apn), "*"); if (l < 1) $ERROR; gsup.pdp_infos[0].apn_enc = apn; gsup.pdp_infos[0].apn_enc_len = l; Also I'm curious / not familiar: how does the asterisk do access control? osmo_apn_from_str() simply encodes the "*", right? -- To view, visit https://gerrit.osmocom.org/1459 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95d69508aafc13e82f5f51fc6fe8f56cd7f45e2b Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes