libosmocore[master]: Remove illegal pkg-config directive

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Dec 16 11:55:48 UTC 2016


Patch Set 1: Code-Review-2

> The part I don't get is: is it enough to just build the library
 > with -fno-strict-aliasing or the applications which link to the
 > library have to be built this way as well? 

I thought the original commit message made it clear. It is about how msgb->cb is type-casted to structures.  Any reader should be able to see where that typecast happens.  I even mentioned it is in header files in my previous comments.  So? It is about the application, not teh library.  why else would it be in the pkg_config cflags for the application ;)

 > The commit refers to
 > linux kernel as a source of inspiration - do you recall by any
 > chance some documentation chapter which I could read to understand
 > this?

just look for the gcc manual on the compiler option used.

-- 
To view, visit https://gerrit.osmocom.org/1426
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87083a74370b2da2e151f03ee06a9acf37f4b5da
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Ruben Undheim <ruben.undheim at gmail.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list